Add tests that use non scalar ntt witnesses #130
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Change folding tests to use new get z vector functions
matthew-a-klein
requested review from
ElijahVlasov,
Fantoni0 and
ivolkg
and removed request for
ElijahVlasov and
Fantoni0
ElijahVlasov
reviewed
Dec 4, 2024
ElijahVlasov
requested changes
Dec 4, 2024
ElijahVlasov
approved these changes
Dec 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We currently have all tests based from scalar ntt witness, in which all basefield elements are the same
Change this so we can test the folding scheme more thoroughly