Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jolt-based sumcheck prove round impl #116

Merged
merged 5 commits into from
Nov 29, 2024
Merged

Jolt-based sumcheck prove round impl #116

merged 5 commits into from
Nov 29, 2024

Conversation

v0-e
Copy link
Member

@v0-e v0-e commented Nov 28, 2024

Jolt-based Sumcheck implementation. Adapted to prove single rounds, following our current logic. Also adapted to run serialized.
Can be employed by enabling the jolt-sumcheck feature.
Provides a comb_func to use other MLE combination schemes, other than the current product-based implementation.

comb_func is currently employed as an argument for prove_as_subprotocol if the feature jolt-sumcheck is enabled. While it could be associated with VirtualPolynomial, adding it there requires dynamic dispatch (or an additional template) which adds a bit of complexity.
comb_func also uses as an argument the ProverState which may provide the user access to some values which evolve throughout the Sumcheck rounds.
If comb_func proves to be useful, we can think of a more suitable interface for it.

Compared to the current Sumcheck implementation, this one performs 1-5% better serialized and 1-4% worse parallelized.

  • This PR also absorbs lattirust VirtualPolynomial.

@v0-e v0-e marked this pull request as ready for review November 28, 2024 21:47
Copy link
Collaborator

@ElijahVlasov ElijahVlasov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome job! LGTM!

@ElijahVlasov ElijahVlasov merged commit f2aea01 into main Nov 29, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants