Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat: constant product amm contract #85

Merged
merged 8 commits into from
Nov 3, 2023
Merged

Feat: constant product amm contract #85

merged 8 commits into from
Nov 3, 2023

Conversation

julio4
Copy link
Contributor

@julio4 julio4 commented Oct 1, 2023 •
edited
Loading

Issue(s): Close #19

Checklist

  • CI Verifier: Run cairo_programs_verifier successfully
  • Contract Tests: Added tests to cover the changes
  • Remix Link: Added a link to open the contract in Remix
  • Deployed Contract (Optional): If possible, include a Voyager link to a deployed contract on Goerli

@julio4 julio4 force-pushed the feat/defi-constant-amm branch from a94056c to 066c65a Compare October 5, 2023 11:56
@julio4 julio4 marked this pull request as ready for review October 5, 2023 12:50
@julio4
Copy link
Contributor Author

julio4 commented Oct 9, 2023

Need some refactor after #90

@julio4 julio4 force-pushed the feat/defi-constant-amm branch from e77307e to 4da3f46 Compare October 10, 2023 09:02
@julio4
Copy link
Contributor Author

julio4 commented Oct 10, 2023 •
edited
Loading

blocked for now: waiting for openzeppelin Cairo >=2.3.0 support

@julio4 julio4 marked this pull request as draft October 10, 2023 13:02
@julio4 julio4 force-pushed the feat/defi-constant-amm branch from 4da3f46 to 6b6f9be Compare October 25, 2023 00:49
@julio4 julio4 force-pushed the feat/defi-constant-amm branch from 6b6f9be to 80d4157 Compare November 3, 2023 08:57
@julio4 julio4 marked this pull request as ready for review November 3, 2023 09:04
@julio4 julio4 merged commit 80459ff into NethermindEth:main Nov 3, 2023
1 check passed
@julio4 julio4 deleted the feat/defi-constant-amm branch November 3, 2023 09:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@swapnilraj swapnilraj swapnilraj left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

feat: Defi - Constant product AMM
2 participants
@julio4 @swapnilraj