feat: handle mail field #53
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gsanchietti
force-pushed
the
mail_notify
branch
4 times, most recently
from
cd25311 to
488064f
Compare
Prevent failure if password expiration is not set. Example of error: additional info: modify/delete: pwdAccountLockedTime: no such attribute
Ignore error if trying to delete the mail field if it does not exists
…48) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
gsanchietti
force-pushed
the
mail_notify
branch
from
a5d8ada to
d24032e
Compare
gsanchietti
force-pushed
the
mail_notify
branch
from
b971c34 to
5b31d36
Compare
DavidePrincipi
approved these changes
Mar 12, 2025
gsanchietti
force-pushed
the
mail_notify
branch
from
5b31d36 to
8630729
Compare
Alter mail field only if required. The cluster UI does not pass the mail field. With the previous implemention, a user modified from the cluster UI would always delete the mail field
gsanchietti
force-pushed
the
mail_notify
branch
from
8630729 to
525323e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NethServer/dev#7229
Update an existing instance: