Fix nginx.conf with TLS verification #13
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When tls_verify is "on", our Nginx configuration seems limited to one backend server only, because the proxy_ssl_name value must match the TLS certificate name. Furthermore we must add the ca-certificates bundle provided by the container image, for the upstream certificate chain verification.
gsanchietti
approved these changes
Mar 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When tls_verify is "on", our Nginx configuration seems limited to one backend server only, because the proxy_ssl_name value must match the TLS certificate name.
Furthermore we must add the ca-certificates bundle provided by the container image (based on Alpine Linux), for the upstream certificate chain verification.
This PR changes only the backend configuration. We ought to modify the UI accordingly.
Refs NethServer/dev#6859
Closes #12