Merge pull request #231 from mdaxini/fix-errorResonse

Make error response message visible in response, and add missing exception messages for endpoints.
Netflix · Mar 2, 2019 · 0c7764e · 0c7764e
2 parents 094fb50 + ae2ecbf
commit 0c7764e
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 10 deletions.
diff --git a/ndbench-core/src/main/java/com/netflix/ndbench/core/resources/NdBenchResource.java b/ndbench-core/src/main/java/com/netflix/ndbench/core/resources/NdBenchResource.java
@@ -87,7 +87,7 @@ public Response initfromscript(@FormDataParam("dynamicplugin") String dynamicPlu
 
         } catch (Exception e) {
             logger.error("Error initializing dynamic plugin from script", e);
-            return sendErrorResponse("script initialization failed for dynamic plugin!"+e);
+            return sendErrorResponse("script initialization failed for dynamic plugin!" + e.getMessage());
 
         }
     }
@@ -105,7 +105,7 @@ public Response startDataFill() throws Exception {
             return sendSuccessResponse("data fill done!");
         } catch (Exception e) {
             logger.error("Error starting datafill", e);
-            return  sendErrorResponse("dataFill failed!");
+            return  sendErrorResponse("dataFill failed!" + e.getMessage());
         }
     }
 
@@ -122,7 +122,7 @@ public Response startDataFillAsync() throws Exception {
             return sendSuccessResponse( "Async data fill started !");
         } catch (Exception e) {
             logger.error("Error starting datafill", e);
-            return  sendErrorResponse("Async dataFill failed to start!");
+            return  sendErrorResponse("Async dataFill failed to start!" + e.getMessage());
         }
     }
 
@@ -139,7 +139,7 @@ public Response conditionalBackfill() throws Exception {
             return sendSuccessResponse("data fill done!");
         } catch (Exception e) {
             logger.error("Error starting datafill", e);
-            return sendErrorResponse("dataFill failed!");
+            return sendErrorResponse("dataFill failed!" + e.getMessage());
         }
     }
 
@@ -156,7 +156,7 @@ public Response verifyBackfill() throws Exception {
             return sendSuccessResponse("data fill done!");
         } catch (Exception e) {
             logger.error("Error starting datafill", e);
-            return sendErrorResponse("dataFill failed!");
+            return sendErrorResponse("dataFill failed!" + e.getMessage());
         }
     }
 
@@ -172,7 +172,7 @@ public Response stopDataFill() throws Exception {
             return sendSuccessResponse("data fill stop!" );
         } catch (Exception e) {
             logger.error("Error stop datafill", e);
-            return sendErrorResponse("dataFill failed!");
+            return sendErrorResponse("dataFill failed!" + e.getMessage());
         }
     }
 
@@ -190,7 +190,7 @@ public Response shutdownDataFill() throws Exception {
             return sendSuccessResponse("data fill stop!" );
         } catch (Exception e) {
             logger.error("Error shutdown datafill", e);
-            return sendErrorResponse("dataFill failed!");
+            return sendErrorResponse("dataFill failed!" + e.getMessage());
         }
     }
 
@@ -206,7 +206,7 @@ public Response init(@PathParam("client") String clientName) throws Exception {
             return sendSuccessResponse("NdBench client initiated!");
         } catch (Exception e) {
             logger.error("Error initializing the client - "+clientName, e);
-            return sendErrorResponse("Client initialization failed!");
+            return sendErrorResponse("Client initialization failed!" + e.getMessage());
         }
     }
 
@@ -328,7 +328,7 @@ public Response stop() throws Exception {
             return sendSuccessResponse("NdBench test stopped!");
         } catch (Exception e) {
             logger.error("Error stopping NdBench test", e);
-            return sendErrorResponse("NdBench stop failed! "+ e.getMessage());
+            return sendErrorResponse("NdBench stop failed! " + e.getMessage());
         }
     }
 

diff --git a/ndbench-core/src/main/java/com/netflix/ndbench/core/util/RestUtil.java b/ndbench-core/src/main/java/com/netflix/ndbench/core/util/RestUtil.java
@@ -85,13 +85,14 @@ public SuccessResponse(String successMessage)
    public static class Result
     {
         public boolean isSuccess;
-        String message;
+        public String message;
 
         Result(boolean result, String resultMessage)
         {
             this.isSuccess = result;
             this.message=resultMessage;
         }
+
         public Result(boolean result)
         {
             this.isSuccess = result;