feature: run heartbeat with Argo daemon containers #1916
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…he argo heartbeat daemon
…mits to heartbeat daemon container
saikonen
changed the title
savingoyal
requested changes
Jul 9, 2024
| @@ -846,6 +846,8 @@ def _compile_workflow_template(self): | |||
| .templates(self._container_templates()) | |||
| # Exit hook template(s) | |||
| .templates(self._exit_hook_templates()) | |||
| # Sidecar templates (Daemon Containers) | |||
| .templates(self._daemon_container_templates()) | |||
There was a problem hiding this comment.
Can we make this optional through the cli - —with-daemon-container/—no-with-daemon-container ? That way folks can opt out if needed
There was a problem hiding this comment.
done. One thought on the wording for the toggle though: Currently we only run heartbeats, and in the future some other run-scope-processes in the default container.
what happens with the toggle though, if we introduce a way for users to launch their own daemon containers alongside tasks? should these also not deploy if --no-with-daemon-container is specified, or should it not apply to user defined ones?
…tainer resources significantly.
…rovider in daemon and use that to register a new run id, and to propagate heartbeats.
…run through the daemon as well.
savingoyal
previously approved these changes
Jul 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introducing run heartbeat updates as an argo daemon container to decouple workflow status from the active workflow pod health.