-
Notifications
You must be signed in to change notification settings - Fork 765
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
deployer with new injection mechanism #1910
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the direction looks good and matches what we had discussed. A few nit comments and a few other general things too:
- docstrings of course
- we are going to have to find a good way to properly generate docstrings/stubs just like for the current object. It shouldn't be too hard but something to think about.
- I haven't looked at the argo impl in detail but got the general idea and I think it looks nice.
OverallFunctions
Classes
For Argo-WorkflowsFunctions
Class
For Step FunctionsFunctions
Class
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor nits but I think this looks good. I haven't closely reviewed the argo/sfn implementations but the interface and methodology looks good.
make deployer docstrings work with API docs
Usage as follows: