Add a rebatch call to RemoteObservable connections between stages. #744
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crioux-stripe
had a problem deploying
to
Integrate Pull Request
GitHub Actions
Failure
crioux-stripe
had a problem deploying
to
Integrate Pull Request
GitHub Actions
Failure
crioux-stripe
requested review from
calvin681,
Andyz26,
hmitnflx,
fdc-ntflx and
dtrager02
as code owners
crioux-stripe
had a problem deploying
to
Integrate Pull Request
GitHub Actions
Failure
Andyz26
approved these changes
Jan 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Adds a similar change to 721 to the connections in RemoteObservable. We're experiencing a lot more stage to stage dropping on the ARM machines with 15Gbit we're using at Stripe. The user needs to set
workerClient.buffer.sizeto take advantage of this.Checklist
./gradlew buildcompiles code correctly./gradlew testpasses all tests