Fix scheduler double booking task executors #733
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Andyz26
requested review from
calvin681,
sundargates,
hmitnflx and
fdc-ntflx
as code owners
Andyz26
had a problem deploying
to
Integrate Pull Request
GitHub Actions
Failure
Andyz26
changed the title
markcho
approved these changes
Dec 17, 2024
| @@ -278,6 +283,15 @@ Instant getLastActivity() { | |||
| return this.lastActivity; | |||
| } | |||
|
|
|||
| Duration getLastSchedulerLeasedDuration() | |||
There was a problem hiding this comment.
Nit: Format
Suggested change
| Duration getLastSchedulerLeasedDuration() | |
| Duration getLastSchedulerLeasedDuration() { |
Andyz26
had a problem deploying
to
Integrate Pull Request
GitHub Actions
Failure
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Problem:
When a TE is returned from here to be used for scheduling, its state remain active until the scheduler trigger another message to update (lock) the state. However when large number of the requests are active at the same time on same sku, the gap between here and the message to lock the state can be large so another schedule request message can be in between and got the same set of TEs.
Solution:
To avoid this, a lease is added to each TE state (based on last scheduled usage timestamp) to temporarily lock the TE to be used again. Since this is only lock between actor messages and lease duration can be short.
Checklist
./gradlew buildcompiles code correctly./gradlew testpasses all tests