Ensure worker failed before first heartbeat gets resubmission #731
+106
−10
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Problem:
The missing heartbeat logic relies on the last HB timestamp to determine whether it should be re-submitted by the job actor or the scheduler. This creates a problem for workers failed right after getting scheduled but before it's able to emit the first heartbeat message. This problem gets amplified when we have higher transient worker startup failures due to other issues.
Solution:
Instead of last heartbeat, use the launched event status to decide whether the job actor should start taking over the job resubmission from the scheduler.
Checklist
./gradlew build
compiles code correctly./gradlew test
passes all tests