Fix sse connection infinite retry failure #729
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Andyz26
requested review from
calvin681,
sundargates,
hmitnflx and
fdc-ntflx
as code owners
Andyz26
had a problem deploying
to
Integrate Pull Request
GitHub Actions
Failure
Andyz26
changed the title
fdc-ntflx
approved these changes
Dec 6, 2024
calvin681
reviewed
Dec 6, 2024
| connectionResetHandler.call(throwable); | ||
| }) | ||
| .retryWhen(retryLogic) | ||
| .doOnCompleted(this::resetConnected); | ||
| .doOnError((Throwable throwable) -> { |
There was a problem hiding this comment.
Having double doOnError (here and on line 251) seems wrong to me.
There was a problem hiding this comment.
I think both will still be called, regardless that there is a retryWhen in between.
There was a problem hiding this comment.
let me try test this. My understanding is the retryWhen will swallow the error so outer doOnError won't see it if it's being retried
calvin681
approved these changes
Dec 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
We noticed that when the SSE connection triggered "doOnError", the SSE HTTP client was closed internally (via resetConn) but the following "retryWhen" operation started an infinite retry action on the closed HTTP Client (and every retry failed right away since the client is not going to start the actual connection).
Solution:
Refactor to split reset and close operations on the SSE client so that the "doOnErro" within the retry loop will only reset instead of closing the client. Added an outer "doOnError" to make sure the client gets closed once the retry loop is broken.
Checklist
./gradlew buildcompiles code correctly./gradlew testpasses all tests