Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase schedule retries #722

Merged
merged 1 commit into from
Oct 31, 2024
Merged

Increase schedule retries #722

merged 1 commit into from
Oct 31, 2024

Conversation

Andyz26
Copy link
Collaborator

@Andyz26 Andyz26 commented Oct 31, 2024

Context

Increasing the default schedule retries config (since the initial scheduling on batch is consolidated to honor the backoff it should be safe now to use a larger retry max to reduce jobs stuck on no resource not retrying anymore).
The follow-up work here could be to extend this to retry forever (e.g. if no resource is available for this scheduling request, keep retrying with proper backoff delay), but given the risk, I will defer this change till we gather more confidence with the new behavior.

Checklist

  • ./gradlew build compiles code correctly
  • Added new tests where applicable
  • ./gradlew test passes all tests
  • Extended README or added javadocs where applicable

Copy link

Test Results

614 tests  ±0   604 ✅ ±0   8m 6s ⏱️ +3s
142 suites ±0    10 💤 ±0 
142 files   ±0     0 ❌ ±0 

Results for commit 47247ad. ± Comparison against base commit 3a936bc.

@Andyz26 Andyz26 merged commit 7f996f8 into master Oct 31, 2024
4 of 5 checks passed
@Andyz26 Andyz26 deleted the andyz/increaseScheduleRetry branch October 31, 2024 22:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants