DynamoDBMasterMonitor: Don't publish MASTER_NULL on Dynamo failure #696
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crioux-stripe
requested review from
calvin681,
sundargates,
Andyz26,
hmitnflx and
fdc-ntflx
as code owners
|
Just realized I have a commented out test here. Working on a fix. |
|
Fixed. |
4 tasks
hmitnflx
approved these changes
Jul 30, 2024
crioux-stripe
deleted the
crioux-stripe/fix-dynamo-lock-master-monitor-null-on-failure
branch
crioux-stripe
had a problem deploying
to
Integrate Pull Request
GitHub Actions
Failure
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
We encountered an issue in which
DynamoDBMasterMonitorwould emit aMASTER_NULLvalue in the event of failing to read or decode the lock from DynamoDB. This caused some minor but unncessary churn as our agents believed the master had changed when it in fact had not. This can be further exacerbated by transient failures in Dynamo or throttling when querying Dynamo.Checklist
./gradlew buildcompiles code correctly./gradlew testpasses all tests