Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename LeadershipManagerZkImpl to LeadershipManagerImpl #694

Merged
merged 1 commit into from
Jul 19, 2024
Merged

Rename LeadershipManagerZkImpl to LeadershipManagerImpl #694

merged 1 commit into from
Jul 19, 2024

Conversation

rfradkin-stripe
Copy link
Contributor

Context

LeadershipManagerZkImpl has no Zk dependencies. Therefore, we should rename it.

Checklist

  • ./gradlew build compiles code correctly
  • Added new tests where applicable
  • ./gradlew test passes all tests
  • Extended README or added javadocs where applicable

Copy link
Collaborator

@hmitnflx hmitnflx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link

Test Results

535 tests  ±0   529 ✅ ±0   7m 54s ⏱️ -3s
139 suites ±0     6 💤 ±0 
139 files   ±0     0 ❌ ±0 

Results for commit 0ed95c5. ± Comparison against base commit c0d0370.

@Andyz26 Andyz26 merged commit dd5a89e into Netflix:master Jul 19, 2024
4 of 5 checks passed
Andyz26 added a commit that referenced this pull request Jul 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants