expose jobVersion, jobJarUrl as part of RuntimeTask interface #689
Conversation
sarahwada-stripe
requested review from
calvin681,
sundargates,
Andyz26,
hmitnflx and
fdc-ntflx
as code owners
| @@ -33,4 +33,9 @@ void initialize( | |||
| UserCodeClassLoader userCodeClassLoader); | |||
|
|
|||
| String getWorkerId(); | |||
|
|
|||
There was a problem hiding this comment.
I would prefer we do not add specific metrics/metadata into these entry-interfaces. can you elaborate on why it's on the runtimeTask for metrics instead of using regular metrics collector tagging? I feel like there are existing metrics path to do this without adding into this interface.
There was a problem hiding this comment.
@Andyz26 thanks for the review!
can you elaborate on why it's on the runtimeTask for metrics instead of using regular metrics collector tagging?
The job metadata is only available as part of the job submission, not the actual running job itself. From my understanding, we need to hook into the task/job submission to get information like version. Right now, we have written our own AgentMain class, and we can hook into the TaskExecutor onTaskStarting to add custom job labels, like the scaffolding that exists here:
Given the context above, do you have a recommendation for a better place to make this change? Happy to move things around, it's possible I've missed a better metrics path when going through the code.
There was a problem hiding this comment.
imo since agent to inner task is not always 1 to 1 it would be more consistent to construct such metrics within the worker runtime where you have access to things like MetricsRegistry (I don't know how your current metrics integration is done into with this one).
There was a problem hiding this comment.
got it, thanks for the feedback! are you opposed to adding jobVersion to the ExecuteStageRequest? I think we'll need it to capture the jobVersion on the worker
sarahwada-stripe
force-pushed
the
swada--runtime-task-expose-version
branch
from
39b131f to
eb10be1
Compare
| @@ -239,4 +239,5 @@ protected Observable<Status> getStatus() { | |||
| public String getWorkerId() { | |||
| return executeStageRequest.getWorkerId().getId(); | |||
| } | |||
|
|
|||
sarahwada-stripe
had a problem deploying
to
Integrate Pull Request
GitHub Actions
Failure
Context
Expose
jobVersion,jobJarUrlas part of RuntimeTask interface.This allows us to add version and sha labels to our job metrics. We'd like these metric labels so we can monitor our automated job deploys.
Checklist
./gradlew buildcompiles code correctly./gradlew testpasses all tests