Reorder

Netflix · Sep 23, 2024 · 1be6221 · 1be6221
1 parent c287833
commit 1be6221
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 5 deletions.
diff --git a/lemur/certificates/cli.py b/lemur/certificates/cli.py
@@ -580,7 +580,7 @@ def reissue_command(old_certificate_name, serial_numbers, notify, commit):
     reissue(old_certificate_name, serial_numbers, notify, commit)
 
 
-def reissue(old_certificate_name, serial_numbers, notify, commit):
+def reissue(old_certificate_name, notify, commit, serial_numbers):
     """
     Reissues certificate with the same parameters as it was originally issued with.
     If no time period is provided, reissues certificate as valid from today to

diff --git a/lemur/common/celery.py b/lemur/common/celery.py
@@ -591,7 +591,7 @@ def certificate_reissue():
     current_app.logger.debug(log_data)
     try:
         notify = current_app.config.get("ENABLE_REISSUE_NOTIFICATION", None)
-        cli_certificate.reissue(None, None, notify, True)
+        cli_certificate.reissue(None, notify, True, None)
     except SoftTimeLimitExceeded:
         log_data["message"] = "Certificate reissue: Time limit exceeded."
         current_app.logger.error(log_data)

diff --git a/lemur/tests/test_certificates.py b/lemur/tests/test_certificates.py
@@ -988,7 +988,7 @@ def test_reissue_command_by_name(
 
     certificate = CertificateFactory(name="to_be_reissued_cert", authority=crypto_authority)
 
-    reissue(certificate.name, None, False, True)
+    reissue(certificate.name, False, True, None)
 
     new_cert = certificate.replaced[0]
     assert new_cert
@@ -1010,7 +1010,7 @@ def test_reissue_command_by_serial_numbers(
     cert2 = CertificateFactory(name="to_be_reissued_cert_2", authority=crypto_authority)
     cert3 = CertificateFactory(name="to_be_reissued_cert_3", authority=crypto_authority)
 
-    reissue(None, [cert1.serial, cert2.serial, cert3.serial], False, True)
+    reissue(None, False, True, [cert1.serial, cert2.serial, cert3.serial])
 
     for cert in [cert1, cert2, cert3]:
         new_cert = cert.replaced[0]
@@ -1034,7 +1034,7 @@ def test_reissue_command_by_name_and_serial_numbers(
     cert3 = CertificateFactory(name="to_be_reissued_cert_3", authority=crypto_authority)
     cert4 = CertificateFactory(name="to_be_reissued_cert_4", authority=crypto_authority)
 
-    reissue(cert1.name, [cert2.serial, cert3.serial, cert4.serial], False, True)
+    reissue(cert1.name, False, True, [cert2.serial, cert3.serial, cert4.serial])
 
     for cert in [cert1, cert2, cert3, cert4]:
         new_cert = cert.replaced[0]