Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add detail for required field error #17

Merged
merged 2 commits into from
Feb 15, 2021
Merged

Add detail for required field error #17

merged 2 commits into from
Feb 15, 2021

Conversation

PePoDev
Copy link
Contributor

@PePoDev PePoDev commented Feb 15, 2021

Description

I use go-env module in our project, It's was cool.

But I found ErrMissingRequiredValue does't show important detail about required field that miss.

Then I try to add what's required field that missing in error message 😊

@PePoDev PePoDev changed the title 🩹 Add detail for required field error Add detail for required field error Feb 15, 2021
@hinshun
Copy link
Contributor

hinshun commented Feb 15, 2021

Prefer if you just refactor to:

type ErrMissingRequiredValue struct {
    Value string
}

@PePoDev
Copy link
Contributor Author

PePoDev commented Feb 15, 2021

@hinshun I'm not sure if that's right.

@hinshun hinshun merged commit e437a7e into Netflix:master Feb 15, 2021
@hinshun
Copy link
Contributor

hinshun commented Feb 15, 2021

Thanks @PePoDev !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants