Added request options for DataSource retry info #970
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -17,7 +17,7 @@ module.exports = function setRequestCycle(model, observer, groups, | |||
| var requestedPaths = requestedAndOptimizedPaths.requestedPaths; | |||
|
|
|||
| // we have exceeded the maximum retry limit. | |||
| if (count === model._maxRetries) { | |||
| if (count > model._maxRetries) { | |||
There was a problem hiding this comment.
Just asking considering the original comparison logic, should this be >=?
There was a problem hiding this comment.
I made the change to align the retry counts with getRequestCycle; one started at 0, the other at 1. Now they both start at 1, which lines up better with the Zuul retry header value.
tquetano-netflix
approved these changes
Jan 22, 2020
jcranendonk
commented
Jan 23, 2020
| @@ -84,7 +84,7 @@ SetResponse.prototype._subscribe = function _subscribe(observer) { | |||
|
|
|||
| // Starts the async request cycle. | |||
| return setRequestCycle( | |||
| model, observer, groups, isJSONGraph, isProgressive, 0); | |||
| model, observer, groups, isJSONGraph, isProgressive, 1); | |||
There was a problem hiding this comment.
@tquetano-netflix The initial value was changed here, in coordination with the retry logic condition.
We can always use an object again if additional parameters become necessary.
jcranendonk
force-pushed
the
ds_retry_info
branch
from
4616363 to
c540f75
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The DataSource for a Model has no insight into the retry mechanism for get and set requests. This PR adds the retry count as one of a set of request options that are passed to
DataSource.getandDataSource.set, so that this information may be used to e.g. manage request balancing and load shedding on the underlying network resource.