Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error null bug #548

Merged
merged 2 commits into from
Sep 14, 2015
Merged

Error null bug #548

merged 2 commits into from
Sep 14, 2015

Conversation

ThePrimeagen
Copy link
Contributor

Found a small bug in how we are reporting errors when found at the end of a reference.

@ThePrimeagen
Copy link
Contributor Author

@sdesai this uses the #547 as a base so I don't have to redo the test once merged in. So merge #547 first before this one.

@@ -55,7 +55,7 @@ function followReference(model, root, nodeArg, referenceContainerArg,
if (type === $ref) {
if (isJSONG) {
onValue(model, next, seed, null, null, null,
reference, isJSONG);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I assume this set of changes goes away, once merged with latest master

ThePrimeagen added a commit that referenced this pull request Sep 14, 2015
@ThePrimeagen ThePrimeagen merged commit e318ed7 into Netflix:master Sep 14, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants