You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The two places in which we call collect (in the upcoming getRequestCycle.js and IdempotentResponse.js) we do not pass in a version flag. That version flag is required to update the graph which would update the size. This is extremely problematic because every request to a dataSource will cause the LRU to be further cleaned up.
A good unit test would be to test lru/collect to ensure size changes. Test a get that will exceed the cache and after the observable completes (some sort of setTimeout) the cache size must be reduced.
The text was updated successfully, but these errors were encountered:
The two places in which we call collect (in the upcoming getRequestCycle.js and IdempotentResponse.js) we do not pass in a version flag. That version flag is required to update the graph which would update the size. This is extremely problematic because every request to a dataSource will cause the LRU to be further cleaned up.
A good unit test would be to test lru/collect to ensure size changes. Test a get that will exceed the cache and after the observable completes (some sort of setTimeout) the cache size must be reduced.
The text was updated successfully, but these errors were encountered: