Fixed falsey atom values being treated missing paths #118
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Paths which returned falsey values (null, 0, false, '') were being treated as missing paths, and hence being returned as empty atoms. See: Netflix/falcor#460 Added unit tests, and get integration test for these falsey value cases.
|
@sdesai I will merge the test once you upload that final test you are writing. There will be a follow PR by Satyen around JSON-Graph output having the same issue. |
ThePrimeagen
added a commit
that referenced
this pull request
Aug 21, 2015
…ingPaths Fixed falsey atom values being treated missing paths
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@michaelbpaulson
Paths which returned falsey values (null, 0, false, '') were being
treated as missing paths, and hence being returned as empty atoms.
See: Netflix/falcor#460
Sending this over for an initial review. This does fix the reported issue, however I still need to work on the
gettests. I don't think they're testing the right use case, because they pass with the older code too.I don't think we should merge until I've sorted out the right set of unit and integration tests.