Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(docker-image): downgrade Python base image and remove pkg_resources #5447

Merged
merged 13 commits into from
Dec 16, 2024

Conversation

rialg
Copy link
Contributor

@rialg rialg commented Nov 8, 2024

  • Downgrade to docker base image to Python 3.11.10, or else replace distutils module (removed in version 3.12)
  • Replace setuptools' pkg_resources modules, which was deprecated, with importlib.
  • Upgrade lxml module

@rialg
Copy link
Contributor Author

rialg commented Nov 11, 2024

Hi @mvilanova , could you take a look at these changes? 🙏
Also, do you know when the next release will be available? Is there anything missing that I could help with?

@mvilanova mvilanova added the bug Something isn't working label Dec 16, 2024
@mvilanova
Copy link
Contributor

Can you fix this?

src/dispatch/common/utils/cli.py:3:46: F401 [*] `importlib.metadata.EntryPoint` imported but unused
  |
1 | import traceback
2 | import logging
3 | from importlib.metadata import entry_points, EntryPoint
  |                                              ^^^^^^^^^^ F401
4 | from sqlalchemy.exc import SQLAlchemyError
  |
  = help: Remove unused import: `importlib.metadata.EntryPoint`

@whitdog47 whitdog47 merged commit e2e731f into Netflix:master Dec 16, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants