Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(slack): update mfa fail messages to not reference specific providers #5437

Merged
merged 3 commits into from
Nov 6, 2024
Merged

chore(slack): update mfa fail messages to not reference specific providers #5437

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
dbe277f
chore(slack): update mfa fail messages to not reference specific prov…
wssheldon Nov 6, 2024
d341963
chore: make click here bold in mfa verification
wssheldon Nov 6, 2024
e611c8c
Merge branch 'master' into chore/slack-msging
wssheldon Nov 6, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions src/dispatch/plugins/dispatch_slack/case/interactive.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,8 +56,8 @@
)
from dispatch.plugins.dispatch_slack.case.messages import (
create_case_message,
create_signal_engagement_message,
create_manual_engagement_message,
create_signal_engagement_message,
)
from dispatch.plugins.dispatch_slack.config import SlackConversationConfiguration
from dispatch.plugins.dispatch_slack.decorators import message_dispatcher
Expand All @@ -72,11 +72,11 @@
entity_select,
incident_priority_select,
incident_type_select,
participant_select,
project_select,
relative_date_picker_input,
resolution_input,
title_input,
participant_select,
)
from dispatch.plugins.dispatch_slack.middleware import (
action_context_middleware,
Expand Down Expand Up @@ -2359,7 +2359,7 @@ def ack_mfa_required_submission_event(
if mfa_enabled:
mfa_text = (
"🔐 To complete this action, you need to verify your identity through Multi-Factor Authentication (MFA).\n\n"
f"Please <{challenge_url}|click here> to open the MFA verification page."
f"Please <{challenge_url}|*click here*> to open the MFA verification page."
)
else:
mfa_text = "✅ No additional verification required. You can proceed with the confirmation."
Expand Down Expand Up @@ -2502,9 +2502,9 @@ def send_engagement_response(
engagement_status = SignalEngagementStatus.denied

if response == MfaChallengeStatus.EXPIRED:
text = "Confirmation failed, the MFA request timed out. Please, have your MFA device ready to accept the push notification and try again."
text = "Confirmation failed, the MFA request timed out. Please try again and complete the MFA verification within the given time frame."
elif response == MfaChallengeStatus.DENIED:
text = f"User {engaged_user} not found in MFA provider. To validate your identity, please register in Duo and try again."
text = f"We couldn't find {engaged_user} in our MFA system."
else:
text = "Confirmation failed. You must accept the MFA prompt."

Expand Down
Loading