Improve our slack api error handling and backoff #4878
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
whitdog47
reviewed
Jun 25, 2024
whitdog47
reviewed
Jun 25, 2024
whitdog47
reviewed
Jun 25, 2024
wssheldon
approved these changes
Jun 25, 2024
Co-authored-by: David Whittaker <84562015+whitdog47@users.noreply.github.com>
Co-authored-by: Jason Schroth <jrobsch@hotmail.com>
Co-authored-by: David Whittaker <84562015+whitdog47@users.noreply.github.com>
Co-authored-by: Jason Schroth <jrobsch@hotmail.com>
Co-authored-by: Jason Schroth <jrobsch@hotmail.com>
Co-authored-by: Jason Schroth <jrobsch@hotmail.com>
jschroth
requested changes
Jun 26, 2024
Co-authored-by: Jason Schroth <jrobsch@hotmail.com>
wssheldon
reviewed
Jun 27, 2024
wssheldon
reviewed
Jun 27, 2024
jschroth
approved these changes
Jun 27, 2024
Co-authored-by: Will Sheldon <114631109+wssheldon@users.noreply.github.com>
metroid-samus
pushed a commit
that referenced
this pull request
Sep 25, 2024
* Improve our slack api error handling and backoff * Update src/dispatch/plugins/dispatch_slack/service.py Co-authored-by: David Whittaker <84562015+whitdog47@users.noreply.github.com> * Update src/dispatch/plugins/dispatch_slack/service.py Co-authored-by: Jason Schroth <jrobsch@hotmail.com> * Update src/dispatch/plugins/dispatch_slack/service.py Co-authored-by: David Whittaker <84562015+whitdog47@users.noreply.github.com> * Update src/dispatch/plugins/dispatch_slack/service.py Co-authored-by: Jason Schroth <jrobsch@hotmail.com> * Update src/dispatch/plugins/dispatch_slack/service.py Co-authored-by: Jason Schroth <jrobsch@hotmail.com> * Update src/dispatch/plugins/dispatch_slack/service.py Co-authored-by: Jason Schroth <jrobsch@hotmail.com> * Changes based on feedback * Update src/dispatch/plugins/dispatch_slack/service.py Co-authored-by: Jason Schroth <jrobsch@hotmail.com> * Update src/dispatch/plugins/dispatch_slack/service.py * Update src/dispatch/plugins/dispatch_slack/service.py Co-authored-by: Will Sheldon <114631109+wssheldon@users.noreply.github.com> --------- Co-authored-by: David Whittaker <84562015+whitdog47@users.noreply.github.com> Co-authored-by: Jason Schroth <jrobsch@hotmail.com> Co-authored-by: Will Sheldon <114631109+wssheldon@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes sleep, defaults to exponential backoff. Respect slack API rate limiting.