New tag selector component #4243
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…com/Netflix/dispatch into enhancement/new-tag-type-attributes
wssheldon
approved these changes
Jan 16, 2024
There was a problem hiding this comment.
Looks good to me! I don't see any glaring issues. After we migrated to Vue 3, I have been trying to use the script setup composition API for new code, as it's the "new" way, and the options API is considered deprecated.
Not saying we should change the new code in this PR but just as an FYI.
wssheldon
reviewed
Jan 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements an improved tag selector allowing for search by tag name, collapsable/expandable tag type sections, and enforced exclusivity. Tags are shown as removable color chips with tag type icons.
New attributes for tag types include: