New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes error when plugin table failed to load if one had a configuration error #3608

Merged

whitdog47 merged 10 commits into master from bug/show-error-if-plugin-fails-to-load

Jul 20, 2023

Contributor

whitdog47 commented Jul 18, 2023

No description provided.


          Fixes error when plugin table failed to load if one had a configurati…

81566ad

…on error

whitdog47 added the bug label

whitdog47 requested a review from wssheldon

July 18, 2023 22:53


          Reformatting for black lint check

20f68e6

wssheldon approved these changes

View reviewed changes

Contributor

wssheldon left a comment

Looks good, the only thing I'd call out is if we know of any recurring failure states we could probably make the error message more descriptive/helpful in the notification toast/snackbar.

wssheldon reviewed

View reviewed changes

src/dispatch/plugin/models.py Outdated Show resolved Hide resolved

wssheldon reviewed

View reviewed changes

src/dispatch/plugin/models.py Outdated Show resolved Hide resolved

wssheldon reviewed

View reviewed changes

src/dispatch/plugin/models.py Outdated Show resolved Hide resolved

wssheldon reviewed

View reviewed changes

src/dispatch/plugin/models.py Outdated Show resolved Hide resolved

wssheldon reviewed

View reviewed changes

src/dispatch/static/dispatch/src/plugin/store.js Outdated Show resolved Hide resolved

whitdog47 and others added 8 commits

July 19, 2023 10:53


          Update src/dispatch/plugin/models.py

9c748da

Co-authored-by: Will Sheldon <114631109+wssheldon@users.noreply.github.com>


          Update src/dispatch/plugin/models.py

bc63bd4

Co-authored-by: Will Sheldon <114631109+wssheldon@users.noreply.github.com>


          Update src/dispatch/plugin/models.py

ed085eb

Co-authored-by: Will Sheldon <114631109+wssheldon@users.noreply.github.com>


          Update src/dispatch/plugin/models.py

929445d

Co-authored-by: Will Sheldon <114631109+wssheldon@users.noreply.github.com>


          Update src/dispatch/static/dispatch/src/plugin/store.js

a5210a0

Co-authored-by: Will Sheldon <114631109+wssheldon@users.noreply.github.com>


          Merge branch 'master' into bug/show-error-if-plugin-fails-to-load

9be1cc1


          Fixing format for lint

9e76e9e


          Merge branch 'master' into bug/show-error-if-plugin-fails-to-load

b8c315e

whitdog47 merged commit 3d253e4 into master

whitdog47 deleted the bug/show-error-if-plugin-fails-to-load branch

July 20, 2023 16:28

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug