Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updates Dispatch Conversation URLs to reflect complete workspace URL #3449

Merged
merged 28 commits into from
Jun 21, 2023
Merged

Updates Dispatch Conversation URLs to reflect complete workspace URL #3449

merged 28 commits into from
Jun 21, 2023

Conversation

metroid-samus
Copy link
Contributor

The Conversation URL for incidents previously pointed to slack.com instead of <domain>.slack.com, which may sometime redirection to different slack space depending on the workspaces a user is signed into in their browser.

@metroid-samus metroid-samus added the bug Something isn't working label May 31, 2023
@metroid-samus metroid-samus requested a review from mvilanova May 31, 2023 22:20
dependabot bot and others added 19 commits May 31, 2023 18:11
@dependabot @metroid-samus
Bump ruff from 0.0.269 to 0.0.270 (#3432)
84ddf4b 
Bumps [ruff](https://github.com/charliermarsh/ruff) from 0.0.269 to 0.0.270.
- [Release notes](https://github.com/charliermarsh/ruff/releases)
- [Changelog](https://github.com/charliermarsh/ruff/blob/main/BREAKING_CHANGES.md)
- [Commits](astral-sh/ruff@v0.0.269...v0.0.270)

---
updated-dependencies:
- dependency-name: ruff
  dependency-type: direct:development
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@dependabot @metroid-samus
Bump google-api-python-client from 2.86.0 to 2.87.0 (#3431)
859cea1 
Bumps [google-api-python-client](https://github.com/googleapis/google-api-python-client) from 2.86.0 to 2.87.0.
- [Release notes](https://github.com/googleapis/google-api-python-client/releases)
- [Changelog](https://github.com/googleapis/google-api-python-client/blob/main/CHANGELOG.md)
- [Commits](googleapis/google-api-python-client@v2.86.0...v2.87.0)

---
updated-dependencies:
- dependency-name: google-api-python-client
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@dependabot @metroid-samus
Bump schemathesis from 3.19.2 to 3.19.3 (#3430)
02d1acb 
Bumps [schemathesis](https://github.com/schemathesis/schemathesis) from 3.19.2 to 3.19.3.
- [Release notes](https://github.com/schemathesis/schemathesis/releases)
- [Changelog](https://github.com/schemathesis/schemathesis/blob/master/docs/changelog.rst)
- [Commits](schemathesis/schemathesis@v3.19.2...v3.19.3)

---
updated-dependencies:
- dependency-name: schemathesis
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@dependabot @metroid-samus
Bump @playwright/test in /src/dispatch/static/dispatch (#3429)
081005e 
Bumps [@playwright/test](https://github.com/Microsoft/playwright) from 1.34.2 to 1.34.3.
- [Release notes](https://github.com/Microsoft/playwright/releases)
- [Commits](microsoft/playwright@v1.34.2...v1.34.3)

---
updated-dependencies:
- dependency-name: "@playwright/test"
  dependency-type: direct:development
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@dependabot @metroid-samus
Bump requests from 2.28.2 to 2.31.0 (#3436)
f44eccb 
Bumps [requests](https://github.com/psf/requests) from 2.28.2 to 2.31.0.
- [Release notes](https://github.com/psf/requests/releases)
- [Changelog](https://github.com/psf/requests/blob/main/HISTORY.md)
- [Commits](psf/requests@v2.28.2...v2.31.0)

---
updated-dependencies:
- dependency-name: requests
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@dependabot @metroid-samus
Bump eslint-plugin-vue in /src/dispatch/static/dispatch (#3435)
59978bd 
Bumps [eslint-plugin-vue](https://github.com/vuejs/eslint-plugin-vue) from 9.14.0 to 9.14.1.
- [Release notes](https://github.com/vuejs/eslint-plugin-vue/releases)
- [Commits](vuejs/eslint-plugin-vue@v9.14.0...v9.14.1)

---
updated-dependencies:
- dependency-name: eslint-plugin-vue
  dependency-type: direct:development
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@dependabot @metroid-samus
Bump vite from 3.2.6 to 3.2.7 in /src/dispatch/static/dispatch (#3434)
20c546f 
Bumps [vite](https://github.com/vitejs/vite/tree/HEAD/packages/vite) from 3.2.6 to 3.2.7.
- [Release notes](https://github.com/vitejs/vite/releases)
- [Changelog](https://github.com/vitejs/vite/blob/v3.2.7/packages/vite/CHANGELOG.md)
- [Commits](https://github.com/vitejs/vite/commits/v3.2.7/packages/vite)

---
updated-dependencies:
- dependency-name: vite
  dependency-type: direct:development
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@dependabot @metroid-samus
Bump coverage from 7.2.6 to 7.2.7 (#3442)
89a924d 
Bumps [coverage](https://github.com/nedbat/coveragepy) from 7.2.6 to 7.2.7.
- [Release notes](https://github.com/nedbat/coveragepy/releases)
- [Changelog](https://github.com/nedbat/coveragepy/blob/master/CHANGES.rst)
- [Commits](nedbat/coveragepy@7.2.6...7.2.7)

---
updated-dependencies:
- dependency-name: coverage
  dependency-type: direct:development
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@dependabot @metroid-samus
Bump google-api-python-client from 2.87.0 to 2.88.0 (#3441)
3caa350 
Bumps [google-api-python-client](https://github.com/googleapis/google-api-python-client) from 2.87.0 to 2.88.0.
- [Release notes](https://github.com/googleapis/google-api-python-client/releases)
- [Changelog](https://github.com/googleapis/google-api-python-client/blob/main/CHANGELOG.md)
- [Commits](googleapis/google-api-python-client@v2.87.0...v2.88.0)

---
updated-dependencies:
- dependency-name: google-api-python-client
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@dependabot @metroid-samus
Bump protobuf from 4.23.1 to 4.23.2 (#3440)
f3bde13 
Bumps [protobuf](https://github.com/protocolbuffers/protobuf) from 4.23.1 to 4.23.2.
- [Release notes](https://github.com/protocolbuffers/protobuf/releases)
- [Changelog](https://github.com/protocolbuffers/protobuf/blob/main/generate_changelog.py)
- [Commits](protocolbuffers/protobuf@v4.23.1...v4.23.2)

---
updated-dependencies:
- dependency-name: protobuf
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@dependabot @metroid-samus
Bump cachetools from 5.3.0 to 5.3.1 (#3439)
e0ed04f 
Bumps [cachetools](https://github.com/tkem/cachetools) from 5.3.0 to 5.3.1.
- [Changelog](https://github.com/tkem/cachetools/blob/master/CHANGELOG.rst)
- [Commits](tkem/cachetools@v5.3.0...v5.3.1)

---
updated-dependencies:
- dependency-name: cachetools
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@dependabot @metroid-samus
Bump pandas from 2.0.1 to 2.0.2 (#3438)
d2c4886 
Bumps [pandas](https://github.com/pandas-dev/pandas) from 2.0.1 to 2.0.2.
- [Release notes](https://github.com/pandas-dev/pandas/releases)
- [Commits](pandas-dev/pandas@v2.0.1...v2.0.2)

---
updated-dependencies:
- dependency-name: pandas
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@wssheldon @metroid-samus
Fix a bug where db_session is not passed in Slack Case creation (#3443)
4e6146e
@mvilanova @metroid-samus
Re-imports the incident auto tagger function (#3448)
7aa8177
@wssheldon @metroid-samus
db_session needs to be passed here (#3447)
b0fe0c4
@kevgliss @metroid-samus
Re scoping the database session close (#3445)
56d2417
@metroid-samus
Merge branch 'master' into origin/bugfix/complete-conversation-urls
f3dba00
@metroid-samus
Responses for message posts and updates now return the message permal…
c778330 
…ink instead of the channel permalink
@metroid-samus
fix lint errors
37506cd
@mvilanova mvilanova merged commit f4c720f into master Jun 21, 2023
@mvilanova mvilanova deleted the origin/bugfix/complete-conversation-urls branch June 21, 2023 23:16
mvilanova added a commit that referenced this pull request Jun 22, 2023
@mvilanova
Revert "Updates Dispatch Conversation URLs to reflect complete worksp…
ee33532 
…ace URL (#3449)"

This reverts commit f4c720f.
@mvilanova mvilanova mentioned this pull request Jun 22, 2023
Closed
@metroid-samus metroid-samus mentioned this pull request Jun 22, 2023
Merged
kevgliss pushed a commit that referenced this pull request Jun 22, 2023
@metroid-samus @mvilanova
Revert "Updates Dispatch Conversation URLs to reflect complete worksp…
8eee40a 
…ace URL (#3449)" (#3522)

This reverts commit f4c720f.

Co-authored-by: Marc Vilanova <39573146+mvilanova@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wssheldon wssheldon wssheldon left review comments

@mvilanova mvilanova mvilanova approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@metroid-samus @mvilanova @wssheldon @kevgliss