Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix/signal schema #2948

Merged
merged 5 commits into from
Feb 7, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions src/dispatch/signal/flows.py
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@
from dispatch.case import service as case_service
from dispatch.case import flows as case_flows
from dispatch.signal import service as signal_service
from dispatch.tag import service as tag_service
from dispatch.signal.models import SignalInstanceCreate, RawSignal


Expand All @@ -27,6 +28,9 @@ def create_signal_instance(
db_session=db_session, signal_instance_in=signal_instance_in
)

# associate any known tags with the signal
tag = tag_service.get_by_name(db_session=db_session, project_id=project.id, name="foo")

signal_instance.signal = signal
db_session.commit()

Expand Down
13 changes: 10 additions & 3 deletions src/dispatch/signal/models.py
Original file line number Diff line number Diff line change
Expand Up @@ -215,14 +215,21 @@ class SignalPagination(DispatchBase):
total: int


class AdditionalMetadata(DispatchBase):
name: Optional[str]
value: Optional[str]
type: Optional[str]
important: Optional[bool]


class RawSignal(DispatchBase):
action: Optional[List[Dict]] = []
additional_metadata: Optional[List[Dict]] = Field([])
additional_metadata: Optional[List[AdditionalMetadata]] = Field([], alias="additionalMetadata")
asset: Optional[List[Dict]] = []
identity: Optional[Dict] = {}
origin_location: Optional[List[Dict]] = Field([])
origin_location: Optional[List[Dict]] = Field([], alias="originLocation")
variant: Optional[str] = None
created_at: Optional[datetime] = Field(None)
created_at: Optional[datetime] = Field(None, fields="createdAt")
id: Optional[str]


Expand Down
1 change: 0 additions & 1 deletion src/dispatch/signal/scheduled.py
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,6 @@ def consume_signals(db_session: SessionLocal, project: Project):
for plugin in plugins:
log.debug(f"Consuming signals. Signal Consumer: {plugin.plugin.slug}")
signal_instances = plugin.instance.consume()

for signal_instance_data in signal_instances:
try:
signal_flows.create_signal_instance(
Expand Down