Allowing tag type to be specified in notification filters (#1447)

Netflix · Jul 16, 2021 · 6bc7271 · 6bc7271
1 parent abb767d
commit 6bc7271
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 0 deletions.
diff --git a/src/dispatch/static/dispatch/src/search/SearchFilterCreateDialog.vue b/src/dispatch/static/dispatch/src/search/SearchFilterCreateDialog.vue
@@ -38,6 +38,15 @@
                           />
                         </v-list-item-content>
                       </v-list-item>
+                      <v-list-item>
+                        <v-list-item-content>
+                          <tag-type-filter-combobox
+                            :project="project"
+                            v-model="filters.tag_type"
+                            label="Tag Types"
+                          />
+                        </v-list-item-content>
+                      </v-list-item>
                       <v-list-item>
                         <v-list-item-content>
                           <incident-type-combobox
@@ -170,6 +179,7 @@ import IncidentStatusMultiSelect from "@/incident/IncidentStatusMultiSelect.vue"
 import TagFilterCombobox from "@/tag/TagFilterCombobox.vue"
 import IncidentTypeCombobox from "@/incident_type/IncidentTypeCombobox.vue"
 import IncidentPriorityCombobox from "@/incident_priority/IncidentPriorityCombobox.vue"
+import TagTypeFilterCombobox from "@/tag_type/TagTypeFilterCombobox.vue"
 import IncidentStatus from "@/incident/IncidentStatus.vue"
 import IncidentPriority from "@/incident/IncidentPriority.vue"
 import SearchUtils from "@/search/utils"
@@ -213,6 +223,7 @@ export default {
         status: [],
         tag: [],
         project: [],
+        tag_type: [],
       },
     }
   },
@@ -222,6 +233,7 @@ export default {
     TagFilterCombobox,
     IncidentTypeCombobox,
     IncidentPriorityCombobox,
+    TagTypeFilterCombobox,
     IncidentStatusMultiSelect,
     IncidentStatus,
     IncidentPriority,
@@ -282,6 +294,7 @@ export default {
         vm.filters.incident_priority,
         vm.filters.status,
         vm.filters.tag,
+        vm.filters.tag_type,
       ],
       () => {
         this.expression = SearchUtils.createFilterExpression(this.filters)

diff --git a/src/dispatch/static/dispatch/src/search/store.js b/src/dispatch/static/dispatch/src/search/store.js
@@ -19,6 +19,7 @@ const getDefaultSelectedState = () => {
       incident_priority: [],
       status: [],
       tag: [],
+      tag_type: [],
       project: [],
     },
   }