This repository has been archived by the owner on Dec 13, 2023. It is now read-only.
Make wait task async. #3775
Merged
Make wait task async. #3775
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
v1r3n
approved these changes
Sep 16, 2023
Young-Zen
reviewed
Sep 27, 2023
| Date expiryDate = parseDate(until); | ||
| long timeInMS = expiryDate.getTime(); | ||
| long now = System.currentTimeMillis(); | ||
| long seconds = ((timeInMS - now) / 1000) + 1; |
There was a problem hiding this comment.
@manan164 Hello, I don't understand why we need to add 1 to the "seconds" variable. It seems to occasionally cause testWaitUntil to fail: https://github.com/Netflix/conductor/actions/runs/6294685428/job/17086871264?pr=3779
There was a problem hiding this comment.
Hi @Young-Zen , good point. I think it may be for rounding purposes. I will change this. Thanks for pointing this out.
There was a problem hiding this comment.
Hi @Young-Zen , I have raised fix for this, #3786
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request type
NOTE: Please remember to run
./gradlew spotlessApplyto fix any format violations.Changes in this PR
Currently, the waiting task can not be less than 30 seconds because the wait task relies on the sweeper to get completed and the sweeper runs every 30 seconds for the workflow.
Now we can decrease the
workflowOffsetTimeoutto some lower value so that workflow will get evaluated faster.However, this approach will put a lot of load on the platform since workflows are evaluated faster.
This PR changes the wait task from sync to async mechanism.
Describe the new behavior from this PR, and why it's needed
Issue #
#3403
Alternatives considered
Using workflowOffsetTimeout with a lower value.