Skip to content
This repository has been archived by the owner on Dec 13, 2023. It is now read-only.

issue-3719: Fix for http task stuck due to NPE #3756

Merged
merged 5 commits into from
Sep 27, 2023

Conversation

saksham2105
Copy link
Contributor

@saksham2105 saksham2105 commented Sep 1, 2023

Pull Request type

  • Bugfix
  • Feature
  • Refactoring (no functional changes, no api changes)
  • Build related changes (Please run ./gradlew generateLock saveLock to refresh dependencies)
  • WHOSUSING.md
  • Other (please describe):

NOTE: Please remember to run ./gradlew spotlessApply to fix any format violations.

Changes in this PR

Implemented the incorrect or empty methods implementation in the DummyPayloadStorage class, such as getLocation(), upload(), and download(). These methods now utilize Disk based approach to store and retrieve data. Prior to this implementation, these methods were either empty or returning null, which led to NullPointerExceptions and caused HTTP workers to become stuck

Alternatives considered

Describe alternative implementation you have considered

We can create another Storage class and change the default value of conductor.external-payload-storage.type property pointing to that class, right now value of conductor.external-payload-storage.type is dummy and this-code is conditionally creating DummyPayloadStorage bean

@manan164
Copy link
Contributor

manan164 commented Sep 5, 2023

Hi @saksham2105 , Please add tests for this change.

@saksham2105
Copy link
Contributor Author

Hi @manan164 , I have added the Unit testcases and tested locally

@v1r3n v1r3n merged commit 5ed77fb into Netflix:main Sep 27, 2023
2 checks passed
@saksham2105 saksham2105 deleted the http-task-stuck-fix branch September 28, 2023 19:01
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants