This repository has been archived by the owner on Dec 13, 2023. It is now read-only.
Add jitter to workflowoffset time #3305
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skorse
changed the title
aravindanr
reviewed
Oct 18, 2022
| } | ||
| break; | ||
| } | ||
| } | ||
| queueDAO.setUnackTimeout( | ||
| DECIDER_QUEUE, workflowModel.getWorkflowId(), postponeDurationSeconds * 1000); | ||
| } | ||
|
|
||
| @VisibleForTesting | ||
| long workflowOffsetWithJitter(long workflowOffsetTimeout) { |
There was a problem hiding this comment.
Can you add more details (comments) about how large the value of jitter can be?
There was a problem hiding this comment.
I've added few lines of comment in the code. Basically, the jitter will be +- 1/3 of workflowoffset value. For 2700 seconds offset, the range of the offset will be between 1800-3600
apanicker-nflx
approved these changes
Oct 18, 2022
aravindanr
approved these changes
Oct 18, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request type
./gradlew generateLock saveLockto refresh dependencies)NOTE: Please remember to run
./gradlew spotlessApplyto fix any format violations.Changes in this PR
Add a jitter to the default wokflowOffsettime to spread out the load on the queue.
Describe the new behavior from this PR, and why it's needed
Issue #
Alternatives considered
Describe alternative implementation you have considered