This repository has been archived by the owner on Dec 13, 2023. It is now read-only.
Set unack/postpone duration based on task state #3289
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skorse
requested review from
apanicker-nflx,
jxu-nflx and
aravindanr
and removed request for
apanicker-nflx and
jxu-nflx
|
Can you add a test for the changes? |
apanicker-nflx
approved these changes
Oct 13, 2022
core/src/main/java/com/netflix/conductor/core/reconciliation/WorkflowSweeper.java
Show resolved
Hide resolved
core/src/main/java/com/netflix/conductor/core/reconciliation/WorkflowSweeper.java
Outdated
Show resolved
Hide resolved
… null and remove unnecessary check
|
@skorse This feature actually made my workflow stuck for a long time if Response Timeout for including task is long... |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request type
./gradlew generateLock saveLockto refresh dependencies)NOTE: Please remember to run
./gradlew spotlessApplyto fix any format violations.Changes in this PR
Set unack/postpone duration based on task state.
Describe the new behavior from this PR, and why it's needed
For workflows with a task in IN_PROGRESS state, the postpone duration is set as (responseTimeoutSeconds + 1). Multiple tasks in IN_PROGRESS state, use the first task. If responseTimeoutSeconds is 0, use a default non-zero value as postpone duration.
For workflows with a task in SCHEDULED state, the postpone duration is set as (pollTimeoutSeconds + 1). If pollTimeoutSeconds is not set, the workflowDef.timeoutSeconds is used for postponeDuration. If the workflowDef.timeoutSeconds is not set, a default non-zero value is used the postpone duration. Multiple tasks in SCHEDULED state, use the first task's value. For deducing the default value, the queue_wait_time metric can be used.
For workflows with a WAIT task in IN_PROGRESS state, the postpone duration is set as the wait timeout seconds computed on the task. If wait timeout is not set, this task is waiting for an external trigger to complete the task. In such cases, the postpone duration will be a default non-zero value.
Alternatives considered
Describe alternative implementation you have considered