This repository has been archived by the owner on Dec 13, 2023. It is now read-only.
do not synchronously eval workflow during update task for select criteria #3146
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
apanicker-nflx
changed the title
jxu-nflx
reviewed
Aug 5, 2022
core/src/main/java/com/netflix/conductor/core/execution/WorkflowExecutor.java
Show resolved
Hide resolved
jxu-nflx
reviewed
Aug 5, 2022
| @@ -168,6 +168,10 @@ public static void recordGauge(String name, long count) { | |||
| gauge(classQualifier, name, count); | |||
| } | |||
|
|
|||
| public static void recordCounter(String name, long count, String... additionalTags) { | |||
There was a problem hiding this comment.
Do you plan to use this method?
There was a problem hiding this comment.
Yes, i noticed that we have a public method for gauge but not for a counter. Further, I plan to use the counter.
jxu-nflx
reviewed
Aug 5, 2022
| @@ -183,6 +183,9 @@ class DecisionTaskSpec extends AbstractSpecification { | |||
| when: "the task 'integration_task_20' is polled and completed" | |||
| def polledAndCompletedTask20Try1 = workflowTestUtil.pollAndCompleteTask('integration_task_20', 'task1.integration.worker') | |||
|
|
|||
| and: "the workflow is evaluated" | |||
| sweep(workflowInstanceId) | |||
There was a problem hiding this comment.
why this changes in tests? same comment for the others?
There was a problem hiding this comment.
As part of the changes introduced, the workflow will be evaluated lazily for a join task, so we simulate the lazy evaluation by calling a sweep here.
apanicker-nflx
force-pushed
the
do_not_sync_eval_fork_update
branch
from
0269543 to
758115a
Compare
apanicker-nflx
changed the title
apanicker-nflx
force-pushed
the
do_not_sync_eval_fork_update
branch
from
758115a to
03a6251
Compare
jxu-nflx
approved these changes
Aug 5, 2022
This was referenced Jun 15, 2023
pmchung
pushed a commit
to routific/conductor
that referenced
this pull request
Sep 6, 2023
…eria (Netflix#3146) * do not synchronously eval workflow under select criteria * expedite lazy evaluation with higher priority
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request type
./gradlew generateLock saveLockto refresh dependencies)NOTE: Please remember to run
./gradlew spotlessApplyto fix any format violations.Changes in this PR
Describe the new behavior from this PR, and why it's needed
Issue #
Alternatives considered
Describe alternative implementation you have considered