This repository has been archived by the owner on Dec 13, 2023. It is now read-only.
Cassandra metadata cache #3097
Merged
Cassandra metadata cache #3097
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jxu-nflx
reviewed
Jul 8, 2022
|
|
||
| @Override | ||
| public List<EventHandler> getAllEventHandlers() { | ||
| return cassandraEventHandlerDAO.getAllEventHandlers(); |
There was a problem hiding this comment.
Not reading from cache first?
jxu-nflx
reviewed
Jul 8, 2022
|
|
||
| @Override | ||
| public List<EventHandler> getEventHandlersForEvent(String event, boolean activeOnly) { | ||
| return cassandraEventHandlerDAO.getEventHandlersForEvent(event, activeOnly); |
jxu-nflx
reviewed
Jul 8, 2022
| return cassandraMetadataDAO.getAllWorkflowDefs(); | ||
| } | ||
|
|
||
| private void refreshTaskDefsCache() { |
There was a problem hiding this comment.
Does @trace create metrics for this method call as well?
There was a problem hiding this comment.
If not, we can add a metrics to the getAllTaskDefsFromDB method of CassdrandMetaDataDao
jxu-nflx
reviewed
Jul 8, 2022
| LOGGER.error("refresh TaskDefs failed ", e); | ||
| } | ||
| } | ||
|
|
||
| private TaskDef getTaskDefFromDB(String name) { |
There was a problem hiding this comment.
Add taskdefname tag to the metric?
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request type
./gradlew generateLock saveLockto refresh dependencies)NOTE: Please remember to run
./gradlew spotlessApplyto fix any format violations.Changes in this PR
Caches for CassandraMetadataDAO and CassandraEventHandlerDAO are extracted into decorators, CacheableMetadataDAO and CacheableEventHandlerDAO respectively
Issue: Including cache within the DAO makes it impossible to opt-out of it.
Alternatives considered
None