Skip to content
This repository has been archived by the owner on Dec 13, 2023. It is now read-only.

[WIP] JSON_JQ inside DO_WHILE task #3046

Closed
wants to merge 1 commit into from

Conversation

manan164
Copy link
Contributor

@manan164 manan164 commented Jun 13, 2022

Hi @apanicker-nflx @aravindanr , There is a bug in do-while task when json_jq task is being used as loopOver task.
The reason being, json_jq has written task execution logic as a part of start method only. So if that is used as one of the loopOver tasks then do-while task wont wait for any task after the json-jq task and schedule a next iteration.
Consider a scenario where loopOver task has three task
HTTP--> JSON_JQ--> SIMPLE
Here the do-while task does not wait for SIMPLE task to get scheduled since JSON_JQ start method has execution logic and it immediately completes. Now there can be two ways to fix this that I can think of,

  1. Rename the start method with the execute method.
  2. Write logic in do-while for this kind of scenario. I have written a comment that I will put into the code once we finalize the approach.

HTTP task also does same thing but do-while works in that case because http task goes into the queue before even calling the start method. If we make HTTP task sync then this issue we can reproduce with http task also.

cc @v1r3n @evgvain

@aravindanr
Copy link
Collaborator

@manan164 I believe this is fixed in this PR, #3072

@manan164 manan164 closed this Jul 1, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants