This repository has been archived by the owner on Dec 13, 2023. It is now read-only.
Add an ack request for each task polled from queue, when polling in batches #2954
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request type
./gradlew generateLock saveLockto refresh dependencies)Changes in this PR
When polling for tasks in batches, it currently does not sends an
ackrequest for the queue, implying that it should be put again at the queue after some previously set timeout.With that change, it will send an ack request for each valid polled task.
Issue #
Alternatives considered
This job could be done inside the above loop which add each task into the returned list, but it may happen that a server dies inside the loop, acknowledging some tasks that could not be returned.
Other possibility is to run the task ack in parallel, although, it may create an unnecessary thread layer and more responsibility to the class/method.