Redis password authentication support

[jmigueprieto]

Pull Request type

• Bugfix
• Feature
• Refactoring (no functional changes, no api changes)
• Build related changes (Please run ./gradlew generateLock saveLock to refresh dependencies)
• WHOSUSING.md
• Other (please describe):

Changes in this PR

Added Redis password authentication support for conductor.db.type

• redis_standalone
• redis_cluster
• redis_sentinel

Issue #2533

---

The password is set as the 4th param in the host configuration. E.g.:

conductor.redis.hosts=localhost:6379:us-east-1c:my_str0ng_pazz

For Cluster and Sentinel configuration the password from the first host is used.

In Sentinel configuration sentinels and redis nodes use the same password.

Alternatives considered

Considered changing RedisProperties to add a new password property un conductor.redis. That would have made it more explicit but since host.getPassword() already exists it seems like an OK alternative if documented properly.

[apanicker-nflx]

Please add documentation about usage of this new field. As such, users would need to read through the code to make use of this feature.

[jmigueprieto]

@apanicker-nflx sure - I'll add some documentation.

What would be the best place for it and its extent?

The only thing I was able to find related to conductor.redis.hosts is a comment in application.properties

#format is host:port:rack separated by semicolon
conductor.redis.hosts=host1:port:rack;host2:port:rack:host3:port:rack

Would it be enough just adding to that? or would you prefer having something like "Configuring Redis" under /docs/how-tos and an entry in spring-configuration-metadata.json?

[apanicker-nflx]

A comment in application.properties would help devs.
Additionally, a section in the docs to elaborate would provide more clarity. @dougsillars Could you point to the best place for adding this documentation?

[dougsillars]

docs/docs/how-tos/redis.md is probably the best place, IMO.

[jmigueprieto]

Added a Redis Configuration page to docs with documentation related to the scope of this PR.

We can later work with @dougsillars to improve it.

[jmigueprieto]

Some tests are failing after rebasing changes, I'll take a look.

[jmigueprieto]

nvm, the build/test issue was fixed before I got a chance to look at it