This repository has been archived by the owner on Dec 13, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 2.3k
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aravindanr
force-pushed
the
start_workflow_task
branch
from
March 22, 2022 21:30
d41d6a8
to
f81bf3f
Compare
apanicker-nflx
approved these changes
Mar 22, 2022
core/src/main/java/com/netflix/conductor/service/WorkflowServiceImpl.java
Show resolved
Hide resolved
core/src/test/groovy/com/netflix/conductor/core/execution/tasks/StartWorkflowSpec.groovy
Outdated
Show resolved
Hide resolved
core/src/test/groovy/com/netflix/conductor/core/execution/tasks/StartWorkflowSpec.groovy
Show resolved
Hide resolved
Please also add documentation for this new system task |
jxu-nflx
approved these changes
Mar 22, 2022
aravindanr
force-pushed
the
start_workflow_task
branch
from
March 23, 2022 17:30
f81bf3f
to
8034162
Compare
Will do. |
@apanicker-nflx @jxu-nflx I realized that the PR does not follow the convention for input parameters for the task. The parameter name is |
I will update the documentation to include the configuration. The Examples section requires some thought and needs screenshots. I will add that in a different PR. |
aravindanr
force-pushed
the
start_workflow_task
branch
2 times, most recently
from
March 24, 2022 05:02
0eb249c
to
6daca90
Compare
aravindanr
force-pushed
the
start_workflow_task
branch
from
March 24, 2022 05:58
6daca90
to
0844b86
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request type
./gradlew generateLock saveLock
to refresh dependencies)Changes in this PR
A new system task called
START_WORKFLOW
that starts a workflow using aStartWorkflowRequest
.