This repository has been archived by the owner on Dec 13, 2023. It is now read-only.
ModelMapper.getLeanCopy() copies tasks #2829
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
apanicker-nflx
approved these changes
Mar 8, 2022
| @@ -0,0 +1,35 @@ | |||
| { | |||
| "name": "workflow_with_synchronous_system_task", | |||
| "description": "A workflow with a user task followed a synchronous task", | |||
There was a problem hiding this comment.
nit: "A workflow with a simple task ... "
| tasks[0].externalOutputPayloadStoragePath == taskOutputPath | ||
| tasks[1].taskType == 'JSON_JQ_TRANSFORM' | ||
| tasks[1].status == Task.Status.COMPLETED | ||
| tasks[1].externalInputPayloadStoragePath == INPUT_PAYLOAD_PATH |
There was a problem hiding this comment.
Consider adding an assert on the json task output
| @@ -1715,15 +1715,15 @@ boolean scheduleTask(WorkflowModel workflow, List<TaskModel> tasks) { | |||
| String.valueOf(workflow.getWorkflowVersion())); | |||
|
|
|||
| // Save the tasks in the DAO | |||
| createdTasks = executionDAOFacade.createTasks(tasks); | |||
| executionDAOFacade.createTasks(tasks); | |||
jxu-nflx
approved these changes
Mar 8, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request type
./gradlew generateLock saveLockto refresh dependencies)Changes in this PR
ModelMapper.getLeanCopy()copies tasks.WorkflowExecutor.scheduleTasksuse the fullTaskModelwhen callingWorkflowSystemTask.start().