This repository has been archived by the owner on Dec 13, 2023. It is now read-only.
Add previousStatus filed to WorkflowModel #2816
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
apanicker-nflx
approved these changes
Mar 4, 2022
aravindanr
reviewed
Mar 7, 2022
| public Status getStatus() { | ||
| return status; | ||
| } | ||
|
|
||
| public void setStatus(Status status) { | ||
| setPreviousStatus(this.status); |
There was a problem hiding this comment.
Should we worry about previousStatus getting overridden if setStatus is called twice?
There was a problem hiding this comment.
Good catch! Added a check for that
jxu-nflx
force-pushed
the
feature/workflow_previousStatus
branch
from
f6feeb6 to
6c1eeaa
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request type
./gradlew generateLock saveLockto refresh dependencies)Changes in this PR
Add previousStatus to WorkflowModel so it can be used to capture status change
Describe the new behavior from this PR, and why it's needed
Issue #
Alternatives considered
Describe alternative implementation you have considered