Support for Retry with LINEAR_BACKOFF #2699
Conversation
* Support for retry with linear backoff. * Scale factor added to control the slope of the linear backoff.
* Support for retry with linear backoff. * Scale factor added to control the slope of the linear backoff.
|
I reran this again locally on my system and the build was successful. Is this a problem with then environment? |
|
@venkag We do not see a significant value gain by adding this retry logic feature, specifically since there isn't a requirement from the community. Could you please provide more details on why this needs to be added to Conductor and what specific usecases you are trying to address here? Also, please note that as part of the contributing guidelines, we recommend starting a discussion to gather inputs from the community and gauge interest. This also helps to finalize the implementation details for a contribution. |
|
Thank you for the feedback @apanicker-nflx ! I had a feeling that I was not following the SOP (Standard Operating Procedures) 😄. Agree that this is not a feature that community did not agree yet. I was hoping that this is non-intrusive change and is complimentary (instead of conflicting with any feature), I assumed, it would be OK to raise a PR directly. This is something that we need internally. We are trying to keep our internal mirror as close to open source version as possible and thats the reason for submitting the PR in the first place. Started a discussion (#2710). Sorry for the confusion. |
|
Thanks for the explanation and for the PR itself. Agreed that it is not a conflicting feature that breaks compatibility, but we still value community insights into new features to ensure that we cover the widest array of possible use cases. Thanks for starting the discussion as well. |
* Support for retry with linear backoff. * Scale factor added to control the slope of the linear backoff. * Adjusting the enum order.
Pull Request type
./gradlew generateLock saveLockto refresh dependencies)Changes in this PR
Support for Retry with LINEAR_BACKOFF
Issue #
Alternatives considered
No alternatives available. This support is added just to have a certain retry behavior.