This repository has been archived by the owner on Dec 13, 2023. It is now read-only.
Bug fix 2573 #2582
Closed
Bug fix 2573 #2582
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
After a discussion with @aravindanr it appears this entire block of code is entirely unnecessary as Could you try if the following simplification works? |
peterlau
reviewed
Nov 16, 2021
| @@ -226,9 +226,14 @@ export default function Execution() { | |||
| if (task) { | |||
There was a problem hiding this comment.
Suggestion: Eliminate all logic in handleSelectedTask. task.domain should be automatically populated by API already.
|
Opend a new PR as this one got mixed with changes from other branch. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request type
#2573