This repository has been archived by the owner on Dec 13, 2023. It is now read-only.
Remove ack from Go client + pass auth to go http client #2470
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CHURLZ
changed the title
|
@aravindanr can we get this through? Current go client is not compatible with v3. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request type
Changes in this PR
Describe the new behavior from this PR, and why it's needed
Based on Issue # #1659, v3 no longer requires workers to ack tasks. The ack step in the go client prevents the worker from executing the task, and was therefore removed.
Authentication was added due to my own setup, where workers need to auth to perform any action on the api. The existing http client only took url, and so would not allow any auth.