Merge pull request #3577 from manan164/failure_workflow_input_fix

Pass complete workflow as input to failure workflow.
Netflix · Apr 19, 2023 · 351243e · 351243e
2 parents 3981a15 + 0a180ac
commit 351243e
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 0 deletions.
diff --git a/core/src/main/java/com/netflix/conductor/core/execution/WorkflowExecutor.java b/core/src/main/java/com/netflix/conductor/core/execution/WorkflowExecutor.java
@@ -651,6 +651,7 @@ public WorkflowModel terminateWorkflow(
                 if (workflow.getFailedTaskId() != null) {
                     input.put("failureTaskId", workflow.getFailedTaskId());
                 }
+                input.put("failedWorkflow", workflow);
 
                 try {
                     String failureWFId = idGenerator.generate();

diff --git a/core/src/test/java/com/netflix/conductor/core/execution/TestWorkflowExecutor.java b/core/src/test/java/com/netflix/conductor/core/execution/TestWorkflowExecutor.java
@@ -2101,6 +2101,9 @@ public void testTerminateWorkflowWithFailureWorkflow() {
                 workflow.getWorkflowId(), startWorkflowInput.getWorkflowInput().get("workflowId"));
         assertEquals(
                 failedTask.getTaskId(), startWorkflowInput.getWorkflowInput().get("failureTaskId"));
+        assertNotNull(
+                failedTask.getTaskId(),
+                startWorkflowInput.getWorkflowInput().get("failedWorkflow"));
     }
 
     @Test

diff --git a/...harness/src/test/groovy/com/netflix/conductor/test/integration/FailureWorkflowSpec.groovy b/...harness/src/test/groovy/com/netflix/conductor/test/integration/FailureWorkflowSpec.groovy
@@ -73,6 +73,7 @@ class FailureWorkflowSpec extends AbstractSpecification {
                 input['failureTaskId'] == workflowFailureTaskId
                 tasks.size() == 1
                 tasks[0].taskType == 'LAMBDA'
+                input['failedWorkflow'] != null
             }
         }
     }
@@ -140,6 +141,7 @@ class FailureWorkflowSpec extends AbstractSpecification {
                 input['failureTaskId'] == workflowFailureTaskId
                 tasks.size() == 1
                 tasks[0].taskType == 'LAMBDA'
+                input['failedWorkflow'] != null
             }
         }
     }