Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IRC rooms in config should start with # #10

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

mrshu
Copy link

@mrshu mrshu commented Apr 20, 2014

It took me a while to realize this.

If they don't it can have undesired side effects (the whole delay_task
and loop_task mechanism will stop working and your log size will
increase dramatically).

It took me a while to realize this.

If they don't it can have undesired side effects (the whole delay_task
and loop_task mechanism will stop working and your log size will
increase dramatically).
@q
Copy link
Contributor

q commented Aug 27, 2014

this might be better reflected in the docs, as this only applies to IRC, whereas jabber/hipchat rooms don't require this. I'll give it a once over tomorrow.

@mrshu
Copy link
Author

mrshu commented Aug 27, 2014

Certainly.

The rationale of this PR was to fix the example config so that when anyone tries to just quickly edit it doesn't have to realize that the channel should start with #.

However, reflecting this in docs does certainly make sense.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants