Add fallback-missing outcome #941
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 6 commits
October 14, 2015 16:03
mattrjacobs
added a commit
that referenced
this pull request
Oct 14, 2015
Add fallback-missing outcome
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
2 changes:
Add a
FALLBACK_MISSINGenum to bothHystrixRollingNumberTypeandHystrixEventType. Anytime the fallback path is encountered, and getFallback is not user-supplied (or throws an UnsupportedOperationException), this counter gets incremented.Add the method
isTerminaltoHystrixEventType. With the addition ofFALLBACK_MISSING, all valid sequences ofHystrixEventTypes should end with a terminalHystrixEventType. This allows any possible consumer of a sequence of metrics to know that a command execution is complete just by observing the `HystrixEventType' sequence.