Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hystrix Dashboard sorts NaN.0/s between error and high-volume when sorting on "error then volume" #692

Closed
nilsmagnus opened this issue Feb 23, 2015 · 0 comments
Closed

Hystrix Dashboard sorts NaN.0/s between error and high-volume when sorting on "error then volume" #692

nilsmagnus opened this issue Feb 23, 2015 · 0 comments

Comments

@nilsmagnus
Copy link

When sorting on "error then volume" and ratePerSecond is "NaN", then "errorThenVolume" will become 0.NaN and be sorted right after the monitor-items with errors, but before monitor-items with volume.

This can be fixed by checking if ratePerSecond is NaN, and then set errorThenVolume to a negative value, or write a custom sorting for tsort().
mattrjacobs added a commit that referenced this issue Feb 23, 2015
@mattrjacobs
Merge pull request #693 from nilsmagnus/master
dc3bc3c 
This fixes #692. If ratePerSecond is NaN, set errorThenVolume to -1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@nilsmagnus