Merge pull request #466 from mattrjacobs/add-unit-tests

Add more comprehensive set of unit tests for HystrixCommand and HystrixObservableCommand
Netflix · Jan 9, 2015 · aac5e8c · aac5e8c
2 parents 157e796 + a305f23
commit aac5e8c
Show file tree

Hide file tree

Showing 3 changed files with 493 additions and 628 deletions.
diff --git a/hystrix-core/src/main/java/com/netflix/hystrix/AbstractCommand.java b/hystrix-core/src/main/java/com/netflix/hystrix/AbstractCommand.java
@@ -62,8 +62,6 @@
 import com.netflix.hystrix.util.HystrixTimer.TimerListener;
 
 /* package */abstract class AbstractCommand<R> implements HystrixInvokableInfo<R>, HystrixObservable<R> {
-    // TODO make this package private
-
     private static final Logger logger = LoggerFactory.getLogger(AbstractCommand.class);
     protected final HystrixCircuitBreaker circuitBreaker;
     protected final HystrixThreadPool threadPool;
@@ -385,7 +383,6 @@ public void call(Subscriber<? super R> observer) {
                             invocationStartTime = System.currentTimeMillis();
 
 
-
                             getRunObservableDecoratedForMetricsAndErrorHandling(performAsyncTimeout)
                                     .doOnTerminate(new Action0() {
 
@@ -779,6 +776,7 @@ public Observable<R> call(Throwable t) {
                     Exception e = originalException;
                     Exception fe = getExceptionFromThrowable(t);
 
+
                     if (fe instanceof UnsupportedOperationException) {
                         logger.debug("No fallback for HystrixCommand. ", fe); // debug only since we're throwing the exception and someone higher will do something with it
 

diff --git a/hystrix-core/src/test/java/com/netflix/hystrix/HystrixCommandTest.java b/hystrix-core/src/test/java/com/netflix/hystrix/HystrixCommandTest.java
@@ -27,6 +27,7 @@
 import org.junit.Before;
 import org.junit.Test;
 
+import rx.Observable;
 import rx.Observer;
 import rx.Scheduler;
 import rx.functions.Action1;
@@ -1992,7 +1993,7 @@ public void run() {
     }
 
     @Test
-    public void testRejectedExecutionSemaphoreWithFallback() {
+    public void testRejectedExecutionSemaphoreWithFallbackViaExecute() {
         final TestCircuitBreaker circuitBreaker = new TestCircuitBreaker();
         final ArrayBlockingQueue<Boolean> results = new ArrayBlockingQueue<Boolean>(2);
 
@@ -2054,6 +2055,71 @@ public void run() {
         assertEquals(2, HystrixRequestLog.getCurrentRequest().getAllExecutedCommands().size());
     }
 
+    @Test
+    public void testRejectedExecutionSemaphoreWithFallbackViaObserve() {
+        final TestCircuitBreaker circuitBreaker = new TestCircuitBreaker();
+        final ArrayBlockingQueue<Observable<Boolean>> results = new ArrayBlockingQueue<Observable<Boolean>>(2);
+
+        final AtomicBoolean exceptionReceived = new AtomicBoolean();
+
+        Runnable r = new HystrixContextRunnable(HystrixPlugins.getInstance().getConcurrencyStrategy(), new Runnable() {
+
+            @Override
+            public void run() {
+                try {
+                    results.add(new TestSemaphoreCommandWithFallback(circuitBreaker, 1, 200, false).observe());
+                } catch (Exception e) {
+                    e.printStackTrace();
+                    exceptionReceived.set(true);
+                }
+            }
+
+        });
+
+        // 2 threads, the second should be rejected by the semaphore and return fallback
+        Thread t1 = new Thread(r);
+        Thread t2 = new Thread(r);
+
+        t1.start();
+        t2.start();
+        try {
+            t1.join();
+            t2.join();
+        } catch (Exception e) {
+            e.printStackTrace();
+            fail("failed waiting on threads");
+        }
+
+        if (exceptionReceived.get()) {
+            fail("We should have received a fallback response");
+        }
+
+        final List<Boolean> blockingList = Observable.merge(results).toList().toBlocking().single();
+
+        // both threads should have returned values
+        assertEquals(2, blockingList.size());
+        // should contain both a true and false result
+        assertTrue(blockingList.contains(Boolean.TRUE));
+        assertTrue(blockingList.contains(Boolean.FALSE));
+
+        assertEquals(1, circuitBreaker.metrics.getRollingCount(HystrixRollingNumberEvent.SUCCESS));
+        assertEquals(0, circuitBreaker.metrics.getRollingCount(HystrixRollingNumberEvent.EXCEPTION_THROWN));
+        assertEquals(0, circuitBreaker.metrics.getRollingCount(HystrixRollingNumberEvent.FAILURE));
+        assertEquals(0, circuitBreaker.metrics.getRollingCount(HystrixRollingNumberEvent.FALLBACK_FAILURE));
+        assertEquals(0, circuitBreaker.metrics.getRollingCount(HystrixRollingNumberEvent.FALLBACK_REJECTION));
+        assertEquals(1, circuitBreaker.metrics.getRollingCount(HystrixRollingNumberEvent.FALLBACK_SUCCESS));
+        assertEquals(1, circuitBreaker.metrics.getRollingCount(HystrixRollingNumberEvent.SEMAPHORE_REJECTED));
+        // the rest should not be involved in this test
+        assertEquals(0, circuitBreaker.metrics.getRollingCount(HystrixRollingNumberEvent.SHORT_CIRCUITED));
+        assertEquals(0, circuitBreaker.metrics.getRollingCount(HystrixRollingNumberEvent.THREAD_POOL_REJECTED));
+        assertEquals(0, circuitBreaker.metrics.getRollingCount(HystrixRollingNumberEvent.TIMEOUT));
+        assertEquals(0, circuitBreaker.metrics.getRollingCount(HystrixRollingNumberEvent.RESPONSE_FROM_CACHE));
+
+        System.out.println("**** DONE");
+
+        assertEquals(2, HystrixRequestLog.getCurrentRequest().getAllExecutedCommands().size());
+    }
+
     /**
      * Tests that semaphores are counted separately for commands with unique keys
      */